Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telemetry] Add telemetry to SbPlayer functions #4068

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

borongc
Copy link
Contributor

@borongc borongc commented Aug 29, 2024

Adding additional Media Telemetry to cover SbPlayer functions.

The rough range of each function:

  1. SbPlayerGetPreferredOutputMode(): 1.5us to 13us
  2. SbPlayerSeek(): 6us to 318us
  3. SbPlayerWriteEndOfStream()/audio: 13us to 6.3ms
  4. SbPlayerWriteEndOfStream()/video: 3us to 2.8ms
  5. SbPlayerSetBounds(): 133us to 26.95ms
  6. SbPlayerSetPlaybackRate(): 6us to 11.17ms
  7. SbPlayerSetVolume(): 7us to 17.89ms
  8. SbPlayerGetInfo(): 1us to 6.8ms
  9. SbPlayerGetAudioConfiguration(): 2us to 22.7ms
  10. SbPlayerGetCurrentFrame(): 5us to 61.7ms

b/303328238

Adding additional Media Telemetry to cover SbPlayer functions.

The rough range of each function:
1. SbPlayerGetPreferredOutputMode(): 1.5us to 13us
2. SbPlayerSeek(): 6us to 318us
3. SbPlayerWriteEndOfStream()/audio: 13us to 6.3ms
4. SbPlayerWriteEndOfStream()/video: 3us to 2.8ms
5. SbPlayerSetBounds(): 133us to 26.95ms
6. SbPlayerSetPlaybackRate(): 6us to 11.17ms
7. SbPlayerSetVolume(): 7us to 17.89ms
8. SbPlayerGetInfo(): 1us to 6.8ms
9. SbPlayerGetAudioConfiguration(): 2us to 22.7ms
10. SbPlayerGetCurrentFrame(): 5us to 61.7ms

b/303328238
@borongc borongc merged commit ea15d82 into youtube:main Aug 30, 2024
304 of 305 checks passed
@borongc borongc deleted the sbplayer_telemetry branch August 30, 2024 16:12
@borongc borongc added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Sep 6, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Sep 6, 2024
Adding additional Media Telemetry to cover SbPlayer functions.

The rough range of each function:
1. SbPlayerGetPreferredOutputMode(): 1.5us to 13us
2. SbPlayerSeek(): 6us to 318us
3. SbPlayerWriteEndOfStream()/audio: 13us to 6.3ms
4. SbPlayerWriteEndOfStream()/video: 3us to 2.8ms
5. SbPlayerSetBounds(): 133us to 26.95ms
6. SbPlayerSetPlaybackRate(): 6us to 11.17ms
7. SbPlayerSetVolume(): 7us to 17.89ms
8. SbPlayerGetInfo(): 1us to 6.8ms
9. SbPlayerGetAudioConfiguration(): 2us to 22.7ms
10. SbPlayerGetCurrentFrame(): 5us to 61.7ms

b/303328238

(cherry picked from commit ea15d82)
borongc added a commit that referenced this pull request Sep 12, 2024
Adding additional Media Telemetry to cover SbPlayer functions.

The rough range of each function:
1. SbPlayerGetPreferredOutputMode(): 1.5us to 13us
2. SbPlayerSeek(): 6us to 318us
3. SbPlayerWriteEndOfStream()/audio: 13us to 6.3ms
4. SbPlayerWriteEndOfStream()/video: 3us to 2.8ms
5. SbPlayerSetBounds(): 133us to 26.95ms
6. SbPlayerSetPlaybackRate(): 6us to 11.17ms
7. SbPlayerSetVolume(): 7us to 17.89ms
8. SbPlayerGetInfo(): 1us to 6.8ms
9. SbPlayerGetAudioConfiguration(): 2us to 22.7ms
10. SbPlayerGetCurrentFrame(): 5us to 61.7ms

b/303328238

(cherry picked from commit ea15d82)
borongc added a commit that referenced this pull request Sep 23, 2024
Adding additional Media Telemetry to cover SbPlayer functions.

The rough range of each function:
1. SbPlayerGetPreferredOutputMode(): 1.5us to 13us
2. SbPlayerSeek(): 6us to 318us
3. SbPlayerWriteEndOfStream()/audio: 13us to 6.3ms
4. SbPlayerWriteEndOfStream()/video: 3us to 2.8ms
5. SbPlayerSetBounds(): 133us to 26.95ms
6. SbPlayerSetPlaybackRate(): 6us to 11.17ms
7. SbPlayerSetVolume(): 7us to 17.89ms
8. SbPlayerGetInfo(): 1us to 6.8ms
9. SbPlayerGetAudioConfiguration(): 2us to 22.7ms
10. SbPlayerGetCurrentFrame(): 5us to 61.7ms

b/303328238

(cherry picked from commit ea15d82)
borongc added a commit that referenced this pull request Sep 28, 2024
…#4095)

Refer to the original PR: #4068

Adding additional Media Telemetry to cover SbPlayer functions.

The rough range of each function:
1. SbPlayerGetPreferredOutputMode(): 1.5us to 13us
2. SbPlayerSeek(): 6us to 318us
3. SbPlayerWriteEndOfStream()/audio: 13us to 6.3ms
4. SbPlayerWriteEndOfStream()/video: 3us to 2.8ms
5. SbPlayerSetBounds(): 133us to 26.95ms
6. SbPlayerSetPlaybackRate(): 6us to 11.17ms
7. SbPlayerSetVolume(): 7us to 17.89ms
8. SbPlayerGetInfo(): 1us to 6.8ms
9. SbPlayerGetAudioConfiguration(): 2us to 22.7ms
10. SbPlayerGetCurrentFrame(): 5us to 61.7ms

b/303328238

Co-authored-by: Bo-Rong Chen <[email protected]>
borongc added a commit that referenced this pull request Oct 15, 2024
kaidokert pushed a commit that referenced this pull request Oct 15, 2024
borongc added a commit that referenced this pull request Oct 16, 2024
…unctions" (#4267)

Reverts #4095

b/303328238
b/373468508
b/373683632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants